ubuntu-phone team mailing list archive

[Tim Peeters <tim.peeters@xxxxxxxxxxxxx>]

Hi Robert,

I looked into your code and I don't see an easy solution for the problem.
Indeed, internally a variable was renamed from isExpanded to
currentlyExpanded but it is considered an implementation detail so the
change was not announced/documented. Replacing isExpanded in your code by
currentlyExpanded makes it work for me on trusty, but then it would break
on precise.

So the two main issues here are:
1. UITK packages for 12.04 are not up-to-date (and perhaps not compatible
with newer versions)
2. In order to change the looks of an option selector delegate, you need to
copy the full OptionSelectorDelegate code

Even if we fix 2, you won't get it on 12.04 at the moment so we need to do
something about both.

Can you report the bugs on https://bugs.launchpad.net/ubuntu-ui-toolkit and
we discuss solutions there? That makes it easier to refer developers to the
issue and to track back decisions that we made to fix the problems.

Thanks,
Tim.


On Mon, Dec 2, 2013 at 5:53 PM, Robert Schroll <rschroll@xxxxxxxxx> wrote:

> On Mon, Dec 2, 2013 at 1:06 PM, Tim Peeters <tim.peeters@xxxxxxxxxxxxx>
> wrote:
>
>> API changes are listed in the CHANGES file, and announced on this mailing
>> list.
>> There have been changes to the OptionSelector API in r796 but they were
>> reverted to avoid problems in r825, so neither r780 or r873 should be
>> affected.
>> If you tell me the specific problems/error messages that you have with
>> the OptionSelector then I can try to help you fix it.
>>
>>
> I'm using a custom OptionSelectorDelegate [1] based on the stock version
> from early September (judging from my commit date).  This works as expected
> on my 12.04 system stuck on r780; it just doesn't open on an up-to-date
> 13.10 system (on a VM), a recent emulator instance, or a device (don't know
> the version, since it isn't mine).
>
> Doing a diff between the versions of OptionSelector.qml, I suspect the
> problem is that listContainer.isExpanded has changed to listContainer.currentlyExpanded.
>  The OptionSelector has also gained currentlyExpanded and itemHeight
> properties and an expansionCompleted signal, but I'd be surprised if these
> were causing problems.
>
> Presumably the fix will be as simple as rebasing my delegate on the
> updated stock OptionSelectorDelegate.  I don't think the user base is large
> enough that I have to worry about supporting both APIs.  This will be
> easier for me to do if my 12.04 system gets the update, but it wouldn't be
> impossible if not.
>
> At the risk of sounding insufferable, I'd like to point out that I was
> worried about these sorts of incompatibilities from when I was first
> pointed in this direction [2].  I don't know if it's worth reviving that
> discussion or not.
>
> I think I need to pay a bit more attention to the CHANGES file, since I
> missed both the changes in r796 and their reversion in r825.
>
> Thanks,
> Robert
>
> [1] https://github.com/rschroll/beru/blob/restricted/ui/components/
> StylableOptionSelectorDelegate.qml
> [2] https://lists.launchpad.net/ubuntu-phone/msg04044.html
>
>
>
>