ubuntu-phone team mailing list archive

[Renato Filho <renato.filho@xxxxxxxxxxxxx>]

Hi all,

I implemented the initial 'Lights' API, this was implemented to be
used by Unity only. It should not be usable by apps. ( I believe the
apparmor will block it if you try to access the leds hardware from any
confined app.).

The current Unity implementation uses this API to make the led with
the same color as the small envelop (notification icon in the
indicators), and keep it blinking while the display is off. (Because
of that the led color changed from blue to green in the past)

In my opinion the led should not be direct accessed from any app, if
several apps try to control the led at the same time, this will be a
chaos. Instead of that we should extend the notification API to
support a extra argument that could be used to help unity to decide
which color to use, or  implement a smart algorithm that check the
messages in the queue and choose a color based on the application icon
color that send the message.

For example if facebook sends a notification the led will be blue if
gmail sends a message it will be white or red.

I do not see any use case where the app needs to direct access or
control leds, and it will be very complex to control the access and
keep the state in sync.

Unity should have exclusive access to the led to be able to implement
the scenarios described on the bug  #1461176.

This is my personal opinion and maybe the Unity guys has different
plans for the led API.


BR
Renato


On Mon, Feb 29, 2016 at 11:06 AM, Michael Zanetti
<michael.zanetti@xxxxxxxxxxxxx> wrote:
>
>
> On 25.02.2016 22:04, Bartosz Kosiorek wrote:
>> Hi.
>>
>> Do you know where current LED notification implementation is made?
>>
>> It will be very useful to start development.
>> Based on that, it will not be too difficult to extend notification feature.
>
> Currently the implementation lives here:
>
> http://bazaar.launchpad.net/~unity-team/unity8/trunk/files/head:/plugins/Lights/
>
> However, I'm not sure if this is the best place for it. I think it was
> more like a quick hack solution to to the LED something before the first
> release and hasn't been touched since.
>
> Br,
> Michael
>
>>
>> Best Regards
>> Bartosz
>>
>> 2016-02-25 19:14 GMT+01:00 Jean-Baptiste Lallement
>> <jean-baptiste.lallement@xxxxxxxxxxxxx
>> <mailto:jean-baptiste.lallement@xxxxxxxxxxxxx>>:
>>
>>     Hi,
>>
>>     Le 25/02/2016 18:27, Francisco Pina Martins a écrit :
>>
>>         When started using my BQ Aquaris E4.5, almost 1 year ago, I noticed
>>         there were 3 LED colours:
>>
>>         Green - Was used when the battery finished charing
>>         Red - Was used when the battery was charging
>>         Blue - Was used to alert for unread notifications
>>
>>         After the first (or second, I can't remember exactly) OTA update the
>>         blue LED was replaced with a green one for notifications.
>>
>>         Is this a feature or a bug? xD
>>
>>     It's more like a not fully implemented feature. It is tracked in
>>     https://bugs.launchpad.net/canonical-devices-system-image/+bug/1461176
>>
>>     JB.
>>
>>         Thanks
>>
>>         Francisco
>>
>>
>>
>>     --
>>     Jean-Baptiste Lallement
>>     Canonical Services Ltd.
>>     IRC: jibel
>>
>>
>>     --
>>     Mailing list: https://launchpad.net/~ubuntu-phone
>>     Post to     : ubuntu-phone@xxxxxxxxxxxxxxxxxxx
>>     <mailto:ubuntu-phone@xxxxxxxxxxxxxxxxxxx>
>>     Unsubscribe : https://launchpad.net/~ubuntu-phone
>>     More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>>
>
>
> --
> Mailing list: https://launchpad.net/~ubuntu-phone
> Post to     : ubuntu-phone@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~ubuntu-phone
> More help   : https://help.launchpad.net/ListHelp
>