ubuntu-sdk-team team mailing list archive

[Arthur Mello <arthur.mello@xxxxxxxxxxxxx>]

Thx for reviewing. Comments bellow

> > // TODO: In  the future check if Paste Formats list has an interesting
> format
> 
> Do/ can we have a bug report for this? The word "interesting" is not all that
> descriptive and I imagine it might warrant some discussion leading to a
> follow-up merge request.

As suggested LP #1657111 was created to trace this. Point is that ContentHub keeps trace of all available pastes data types and UITK Components could use that to decide what paste datas would be displayed for users. But how that would work (and if it is really something could to have) needs further discussion.

> > #define CONTHUB_TRACE(params) qCDebug(ucContentHub) << params
> 
> If you don't mind my being a little nit-picky here, please make that
> CONTENT_HUB_TRACE.

fixed

> > qDebug() << "[UITK ContentHub] AppArmor profile:" << appProfile;
> 
> This should be using CONTHUB_TRACE as well.

fixed

> > target: Private.UCContentHub
> > onPasteSelected: {
> > //FIXME if (control.activeFocus) {
> 
> What's with this?

That is an issue with current implementation. ContentHub pasteboard keeps track of the link between launched trust sessions and applications via appId. So whenever a paste is selected from a trust session, app is notified but all available TextField/TextArea get data pasted on it. For example, if we paste on messaging-app TextArea the destination TextField get same data pasted. I was trying to keep track of which component requested the data with looking for activeFocus but this does not seem to work. Suggestions on how to properly do that?

> > if (Private.UCContentHub.canPaste) {
> 
> Wondering, is this "the" way any component would be implementing pasting? If
> so, perhaps make it Labs rather than Private, so it can be implemented by
> third party components.
> Although I'm happy for it to be a FIXME with a bug number.

I have no strong opinion about it. I keep it as Private since there are (or at least we need to have) some discussion going on about integration of this ContentHub clipboard UI with other components (like where/how to paste an image or a pdf file) and with apps that do not use UITK for example. I imagine things here can still change in near future. But we can totally make it Lab if you guys prefer. 
-- 
https://code.launchpad.net/~artmello/ubuntu-ui-toolkit/ubuntu-ui-toolkit-clipboard-dbus/+merge/314072
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.