← Back to team overview

ubuntu-server-ec2-testing-dev team mailing list archive

Re: [Merge] lp:~daniel-thewatkins/ec2-automated-tests/refactor-duplication into lp:ec2-automated-tests

 

Review: Needs Information tenative approval

Yeah, the whitespace is a bit of pain in terms of reviewing the changes. But I don't want to worry about that now; in the future a seperate commit would be most appreciated for whitespace changes. 

This looks sane to me, however, before we roll this out, please get into Jerff and test this with the 14.10 EC2 tests. I would recommend that you copy the 14.10 EC2 job, change it to use your branch and confirm that it works first. If it works, then go ahead and merge the code. 

Tenatively approved, pending real-world test case run. 
-- 
https://code.launchpad.net/~daniel-thewatkins/ec2-automated-tests/refactor-duplication/+merge/234444
Your team Ubuntu Server ec2 Testing Developers is subscribed to branch lp:ec2-automated-tests.


References