ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/tags-rider into lp:reminders-app.

Commit message:
use the knight rider indicator for the tags page too

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/tags-rider/+merge/251816
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/tags-rider into lp:reminders-app.

=== modified file 'src/app/qml/ui/TagsPage.qml'
--- src/app/qml/ui/TagsPage.qml	2015-03-04 00:23:45 +0000
+++ src/app/qml/ui/TagsPage.qml	2015-03-04 19:50:00 +0000
@@ -102,12 +102,6 @@
                 }
             }
 
-            ActivityIndicator {
-                anchors.centerIn: parent
-                running: tags.loading
-                visible: running
-            }
-
             Scrollbar {
                 flickableItem: parent
             }
@@ -120,6 +114,11 @@
         }
     }
 
+    BouncingProgressBar {
+        anchors.top: parent.top
+        visible: tags.loading
+    }
+
     Label {
         anchors.centerIn: parent
         visible: !tags.loading && tagsListView.count == 0