ubuntu-touch-coreapps-reviewers team mailing list archive

[Richard Somlói <ricsipontaz@xxxxxxxxx>]

Richard Somlói has proposed merging lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app.

Requested reviews:
  Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
  Bug #1428501 in Ubuntu Calendar App: "Translatable string change suggestion"
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1428501

For more details, see:
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878

In the week view the text which shows the actual week should be more translation friendly 

For example:

In english: W9
Actual hungarian translation: h9 (which is not reflect what is it)
Better solution: 9. h or 9. hét
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app.

=== modified file 'TimeLineHeader.qml'
--- TimeLineHeader.qml	2015-02-26 16:44:43 +0000
+++ TimeLineHeader.qml	2015-03-05 08:07:05 +0000
@@ -45,7 +45,7 @@
             Label{
                 id: weekNumLabel
                 objectName: "weeknumber"
-                text: i18n.tr("W") + root.weekNumber
+                text: i18n.tr("W%1").arg(root.weekNumber)
                 fontSize: "small"
                 height: units.gu(5)
                 width: parent.width

=== modified file 'po/com.ubuntu.calendar.pot'
--- po/com.ubuntu.calendar.pot	2015-02-18 19:11:05 +0000
+++ po/com.ubuntu.calendar.pot	2015-03-05 08:07:05 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-02-18 19:09+0000\n"
+"POT-Creation-Date: 2015-03-05 09:04+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@xxxxxx>\n"
@@ -23,21 +23,21 @@
 msgid "Today"
 msgstr ""
 
-#: ../AgendaView.qml:91
+#: ../AgendaView.qml:92
 msgid "No upcoming events"
 msgstr ""
 
-#: ../AgendaView.qml:94
+#: ../AgendaView.qml:95
 msgid "You have no calendars enabled"
 msgstr ""
 
-#: ../AgendaView.qml:104
+#: ../AgendaView.qml:105
 msgid "Enable calendars"
 msgstr ""
 
 #. TRANSLATORS: the first argument (%1) refers to a start time for an event,
 #. while the second one (%2) refers to the end time
-#: ../AgendaView.qml:166 ../EventBubble.qml:131
+#: ../AgendaView.qml:168 ../EventBubble.qml:131
 #, qt-format
 msgid "%1 - %2"
 msgstr ""
@@ -59,7 +59,7 @@
 msgstr[0] ""
 msgstr[1] ""
 
-#: ../CalendarChoicePopup.qml:33 ../EventActions.qml:41
+#: ../CalendarChoicePopup.qml:33 ../EventActions.qml:59
 msgid "Calendars"
 msgstr ""
 
@@ -69,11 +69,11 @@
 
 #. TRANSLATORS: Please translate this string  to 15 characters only.
 #. Currently ,there is no way we can increase width of action menu currently.
-#: ../CalendarChoicePopup.qml:51
+#: ../CalendarChoicePopup.qml:51 ../EventActions.qml:36
 msgid "Sync"
 msgstr ""
 
-#: ../CalendarChoicePopup.qml:51
+#: ../CalendarChoicePopup.qml:51 ../EventActions.qml:36
 msgid "Syncing"
 msgstr ""
 
@@ -101,7 +101,7 @@
 #. TRANSLATORS: this is a time formatting string,
 #. see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid expressions.
 #. It's used in the header of the month and week views
-#: ../DayView.qml:58 ../MonthView.qml:56 ../WeekView.qml:60
+#: ../DayView.qml:59 ../MonthView.qml:57 ../WeekView.qml:61
 msgid "MMMM yyyy"
 msgstr ""
 
@@ -154,7 +154,7 @@
 msgid "Edit this"
 msgstr ""
 
-#: ../EventActions.qml:32 ../NewEvent.qml:283
+#: ../EventActions.qml:50 ../NewEvent.qml:283
 msgid "New Event"
 msgstr ""
 
@@ -390,15 +390,16 @@
 msgid "2 weeks"
 msgstr ""
 
-#: ../TimeLineHeader.qml:47
-msgid "W"
+#: ../TimeLineHeader.qml:48
+#, qt-format
+msgid "W%1"
 msgstr ""
 
-#: ../TimeLineHeader.qml:59
+#: ../TimeLineHeader.qml:60
 msgid "All Day"
 msgstr ""
 
-#: ../YearView.qml:53
+#: ../YearView.qml:54
 #, qt-format
 msgid "Year %1"
 msgstr ""