ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/reenable-alarm-tests into lp:ubuntu-clock-app.

Commit message:
Re-enabled alarm tests on phone which were originally disabled due to upstream autopilot bug.

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
  Bug #1426108 in Ubuntu Clock App: "re-enable test_add_recurring_type_alarm_must_add_to_alarm_list"
  https://bugs.launchpad.net/ubuntu-clock-app/+bug/1426108

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/reenable-alarm-tests/+merge/253291

Re-enabled alarm tests on phone which were originally disabled due to upstream autopilot bug.
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/reenable-alarm-tests into lp:ubuntu-clock-app.

=== modified file 'debian/changelog'
--- debian/changelog	2015-03-12 23:23:31 +0000
+++ debian/changelog	2015-03-17 22:37:01 +0000
@@ -12,6 +12,8 @@
   * Fixed empty state description not wrapping (LP: #1428165)
   * Fixed edit alarm crash issue in vivid (thanks to Zsombor) (LP: #1429273)
   * Fixed strings not following gettext-style plural forms. (LP: #1431446)
+  * Renabled create alarm tests on device which were disabled due to upstream bug
+    in autopilot. (LP: #1426108)
 
   [Brendan Donegan]
   * Fixed AP failure by waiting for the bottom edge tip visible property to be true

=== modified file 'tests/autopilot/ubuntu_clock_app/tests/test_alarm.py'
--- tests/autopilot/ubuntu_clock_app/tests/test_alarm.py	2014-10-02 19:52:16 +0000
+++ tests/autopilot/ubuntu_clock_app/tests/test_alarm.py	2015-03-17 22:37:01 +0000
@@ -71,12 +71,6 @@
 
         self.page = self.main_view.open_alarm()
 
-    # TODO
-    # Due to bug https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1328600
-    # this test cannot be run on device, so until the bug is not fixed we are
-    # skipping the test if model not Desktop.
-    @unittest.skipIf(model() != 'Desktop',
-                     "datepicker does not work correctly on device")
     def test_add_recurring_type_alarm_must_add_to_alarm_list(self):
         """Test to check if alarms are saved properly