← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/reminders-app/align-section-headers into lp:reminders-app

 

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/align-section-headers into lp:reminders-app.

Commit message:
align section headers with delegate content

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
  Bug #1430188 in Ubuntu Reminders app: "Align note preview text with header and subheaders"
  https://bugs.launchpad.net/reminders-app/+bug/1430188

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/align-section-headers/+merge/253293
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/align-section-headers into lp:reminders-app.
=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2015-03-08 18:47:51 +0000
+++ src/app/qml/ui/NotesPage.qml	2015-03-17 23:08:29 +0000
@@ -232,7 +232,7 @@
             height: units.gu(5)
             showDivider: false
             RowLayout {
-                anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(2) }
+                anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(1) }
                 Label {
                     text: section
                     Layout.fillWidth: true

=== modified file 'src/app/qml/ui/RemindersPage.qml'
--- src/app/qml/ui/RemindersPage.qml	2015-03-01 22:32:41 +0000
+++ src/app/qml/ui/RemindersPage.qml	2015-03-17 23:08:29 +0000
@@ -73,7 +73,7 @@
             section.delegate: Empty {
                 height: units.gu(5)
                 RowLayout {
-                    anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(2) }
+                    anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(1) }
                     Label {
                         text: section
                         Layout.fillWidth: true


Follow ups