ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app.

Commit message:
remove close button from sorting dialog

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
  Bug #1430199 in Ubuntu Reminders app: "Remove Close button from Sort by dialog"
  https://bugs.launchpad.net/reminders-app/+bug/1430199

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/remove-sorting-close-button/+merge/253296
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app.

=== modified file 'src/app/qml/components/SortingDialog.qml'
--- src/app/qml/components/SortingDialog.qml	2015-02-21 14:13:29 +0000
+++ src/app/qml/components/SortingDialog.qml	2015-03-17 23:33:54 +0000
@@ -33,12 +33,9 @@
                     i18n.tr("Title (ascending)"),
                     i18n.tr("Title (descending)")
                 ]
-            }
 
-            Button {
-                text: i18n.tr("Close")
-                onClicked: {
-                    root.sortOrder = optionSelector.selectedIndex
+                onDelegateClicked: {
+                    root.sortOrder = index
                     root.accepted();
                     PopupUtils.close(dialog);
                 }