ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Riccardo Padovani has proposed merging lp:~rpadovani/ubuntu-calculator-app/fixFavouriteGhost into lp:ubuntu-calculator-app/reboot.

Commit message:
Fix favourite that remains in favourite page after deletion

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
  Bug #1436926 in Ubuntu Calculator App: "[reboot] Deleting calculations doesn't remove favorites"
  https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1436926

For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixFavouriteGhost/+merge/254282

Fix favourite that remains in favourite page after deletion
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~rpadovani/ubuntu-calculator-app/fixFavouriteGhost into lp:ubuntu-calculator-app/reboot.

=== modified file 'app/ui/FavouritePage.qml'
--- app/ui/FavouritePage.qml	2015-03-11 08:31:12 +0000
+++ app/ui/FavouritePage.qml	2015-03-26 16:23:49 +0000
@@ -52,7 +52,7 @@
         model: calculationHistory.getContents();
 
         delegate: ListItem.Empty {
-            visible: model.isFavourite
+            visible: model.isFavourite && model.dbId != -1
             height: visible ? units.gu(6) : 0
 
             MouseArea {