ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #01374
[Merge] lp:~nik90/ubuntu-weather-app/minor-headerrow-tweak into lp:ubuntu-weather-app/reboot
The proposal to merge lp:~nik90/ubuntu-weather-app/minor-headerrow-tweak into lp:ubuntu-weather-app/reboot has been updated.
Commit Message changed to:
- Adjusted the top margin spacing of the location name shown in the home page to 2 grid units as shown in the design spec [1].
- Improved HeaderRow.qml by using RowLayout which allows us to remove calculations like width: parent.width - spacing - icon.width and so on.
- Minor code clean up of LocationsPage.qml
[1] https://docs.google.com/presentation/d/1tXcyMBvJAYvwFvUAmTTYzmBP2NFQgbG_Gy8e2gv91kU/edit#slide=id.g3c301e3c2_05
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-weather-app/minor-headerrow-tweak/+merge/255407
--
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~nik90/ubuntu-weather-app/minor-headerrow-tweak into lp:ubuntu-weather-app/reboot.
Follow ups