← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1418648 into lp:ubuntu-docviewer-app

 

I had a look on this, and there are a few components that steals the focus.

When loading a PDF file, you'll see that the bottom edge tip is visible (that means that has the active focus)
The first time the "go to page" dialog is opened, the virtual keyboard flicks and then disappears.
Tap on the TextField (get the focus) and close the dialog.
You'll see that the bottom edge tip is not visible (= no active focus). If you try to open the dialog again, everything works as expected.

The same issue affects filemanager-app, when the user tries to open the "unlock advanced options" dialog or any other dialog which has a TextInput (e.g. "rename file" or "create folder").

The code that this MP would replace is the code used also in filemanager-app[1], and it was supposed to work, according to the SDK team (see bug #1361744, reported in ref. no. 1)

I feel like this is an upstream bug, since also the example in the documentation[2], which is supposed to work, doesn't work if it's put inside a Dialog.

I'd say that for the moment it's better to keep the code as it is now, and not to merge this MP.
Another temporary solution I'd suggest is to remove all the code that tries to give the active focus to the TextInput, in order to hide this issue.


[1]: https://code.launchpad.net/~ajalkane/ubuntu-filemanager-app/rename-textfield-focus
[2]: http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Components.TextField/
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1418648/+merge/256354
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.


References