ubuntu-touch-coreapps-reviewers team mailing list archive

["Gary.Wang" <Gary.Wang@xxxxxxxxxxxxx>]

Thanks for your reply.
I got your point that the wrong end date causes this issue for recurrence Event.
But.....
As u can see in the log. In fact, there is 3 all day event items(items.length) returned from EDS engine.However It shows 6 items in log.The reason for this because we include event.endDateTime in the condition.
for(var d = event.startDateTime; d <= event.endDateTime; d = d.addDays(1)) {

So if period of all day event outlasts 24 hours for single day, then corresponding log will change from 
qml: Thu Jun 11 00:00:00 2015 GMT+0900---Thu Jun 11 00:00:00 2015 GMT+0900
to
qml: Thu Jun 11 00:00:00 2015 GMT+0900---Fri Jun 12 00:00:00 2015 GMT+0900
qml: Thu Jun 11 00:00:00 2015 GMT+0900---Fri Jun 12 00:00:00 2015 GMT+0900

All day event for single day will be broken as well.

my personal option for this is if 
*.length of event items returned from EDS is right 
*.start date of event is right
Then from EDS layer, I think the results is *right*, even through end date is not correct since end date is not mandatory parameter to check all day event.
   
So I think this patch can fix it if there is no need to do some major code change on EDS engine and decrease risk of introducing new bugs.


-- 
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/1455377/+merge/259207
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.