ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-fix-duplicate-location-popup into lp:ubuntu-weather-app/reboot.

Commit message:
Fix broken popup component

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-fix-duplicate-location-popup/+merge/263207

Fix broken popup component. Without this popup, the user gets no feedback as to whether the location was added.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-fix-duplicate-location-popup into lp:ubuntu-weather-app/reboot.

=== modified file 'app/ui/AddLocationPage.qml'
--- app/ui/AddLocationPage.qml	2015-06-21 20:14:39 +0000
+++ app/ui/AddLocationPage.qml	2015-06-28 23:38:34 +0000
@@ -234,7 +234,7 @@
                 if (storage.addLocation(citiesModel.get(index))) {
                     mainPageStack.pop()
                 } else {
-                    PopupUtils.open(locationExistsComponent, addPage)
+                    PopupUtils.open(locationExistsComponent, addLocationPage)
                 }
             }
         }