ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-error-message-fix into lp:ubuntu-calculator-app.

Commit message:
Fix confusing error messages

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
  Bug #1469533 in Ubuntu Calculator App: "math.js SyntaxError: Parenthesis ) expected"
  https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1469533

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-error-message-fix/+merge/263601

Fix confusing error messages
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-error-message-fix into lp:ubuntu-calculator-app.

=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml	2015-06-20 10:51:24 +0000
+++ app/ubuntu-calculator-app.qml	2015-07-01 22:58:00 +0000
@@ -167,7 +167,7 @@
             try {
                 shortFormula = formatBigNumber(mathJs.eval(shortFormula));
             } catch(exception) {
-                console.log("Error: math.js " + exception.toString() + " engine formula:" + shortFormula);
+                console.log("Debug: Temp result: " + exception.toString() + " engine formula:" + shortFormula);
             }
 
             isFormulaIsValidToCalculate = false;
@@ -221,7 +221,6 @@
             for (var i = 0; i < numberOfOpenedBrackets; i++) {
                 deleteLastFormulaElement();
             }
-            console.log("Error: math.js " + exception.toString() + " engine formula:" + longFormula);
             errorAnimation.restart();
             return false;
         }