ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Review: Needs Fixing

I have one nitpicky comment on commentary.

Diff comments:

> === modified file 'app/components/ColumnFlow.qml'
> === modified file 'app/components/Flickables/CardView.qml'
> --- app/components/ColumnFlow.qml	2015-06-07 12:35:42 +0000
> +++ app/components/ColumnFlow.qml	2015-07-02 18:17:23 +0000
> @@ -492,7 +492,12 @@
>  
>      function setDelayRebuildIndex(index)
>      {
> -        if (delayRebuildIndex === -1 || index < lastIndex) {
> +        // Only update the delay index if it isn't set (-1) or

Let's remove this "new line" so the full commentary is intact.

> +        //
> +        // is within the size of the model (lastIndex)
> +        // and is lower than the current delayed index
> +        if (delayRebuildIndex === -1 ||
> +                (index < delayRebuildIndex && index < lastIndex)) {
>              delayRebuildIndex = index
>          }
>      }


-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1470755-playlist-0-append/+merge/263707
Your team Music App Developers is subscribed to branch lp:music-app.