← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview into lp:ubuntu-clock-app

 

Review: Needs Information

Indeed, sorry for the wrong review. 

+                        alarmSettings.volume = value
+                        previewAlarmVolume.volume = value/100

Why you set the volume of the preview at 1/100 of the actual volume?
Also, why did you drop the call to formatValue()?
-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.


Follow ups

References