ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

The reason he is dividing by 100 is because the slider value is 1 to 100
and the volume variable is from 0 to 1.

On Sun, Jul 19, 2015 at 12:40 PM, Riccardo Padovani <riccardo@xxxxxxxxxxxxx>
wrote:

> Review: Needs Information
>
> Indeed, sorry for the wrong review.
>
> +                        alarmSettings.volume = value
> +                        previewAlarmVolume.volume = value/100
>
> Why you set the volume of the preview at 1/100 of the actual volume?
> Also, why did you drop the call to formatValue()?
> --
>
> https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783
> You are reviewing the proposed merge of
> lp:~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview into
> lp:ubuntu-clock-app.
>

-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.