ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1477366-SongsView-album-art into lp:music-app.

Commit message:
Fix SongsView album art for albums and genres

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1477366 in Ubuntu Music App: "Music app does not show album art now on the SongsPage for an album or genre"
  https://bugs.launchpad.net/music-app/+bug/1477366

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1477366-SongsView-album-art/+merge/265623

Fix SongsView album art for albums and genres

When the count changes we should NOT get the album/genre cover arts from the Playlist db... sigh.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1477366-SongsView-album-art into lp:music-app.

=== modified file 'app/ui/SongsView.qml'
--- app/ui/SongsView.qml	2015-07-17 22:35:11 +0000
+++ app/ui/SongsView.qml	2015-07-23 02:35:59 +0000
@@ -187,7 +187,11 @@
         objectName: "songspage-listview"
         width: parent.width
 
-        onCountChanged: songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
+        onCountChanged: {
+            if (songStackPage.line1 === i18n.tr("Playlist")) {
+                songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2) 
+            }
+        }
 
         header: BlurredHeader {
             id: blurredHeader