← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1477502 into lp:ubuntu-docviewer-app

To: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
From: Roman Shchekin <mrqtros@xxxxxxxxx>
Date: Fri, 24 Jul 2015 10:21:21 -0000
In-reply-to: <20150724091531.29518.37530.launchpad@ackee.canonical.com>
Reply-to: mp+265792@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Seems ok for me.
P.S. 
Qt.formatTime() is little bit easier to use. Why do you use Locale.timeFormat() ?
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1477502/+merge/265792
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.

References

[Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1477502 into lp:ubuntu-docviewer-app
From: Stefano Verzegnassi, 2015-07-24