ubuntu-touch-coreapps-reviewers team mailing list archive

[Kunal Parmar <pkunal.parmar@xxxxxxxxx>]

Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/MonthView-Indicator into lp:ubuntu-calendar-app.

Commit message:
resolves Bug #1479533 

Requested reviews:
  Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
  Bug #1479533 in Ubuntu Calendar App: "Monthly view in landscape orientation"
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1479533

For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/MonthView-Indicator/+merge/266655

resolves Bug #1479533 
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/MonthView-Indicator into lp:ubuntu-calendar-app.

=== modified file 'MonthComponentDateDelegate.qml'
--- MonthComponentDateDelegate.qml	2015-06-11 12:24:41 +0000
+++ MonthComponentDateDelegate.qml	2015-08-02 05:09:48 +0000
@@ -14,6 +14,7 @@
 
     Loader {
         sourceComponent: (isToday && isCurrentMonth) || isSelected ? highLightComp : undefined
+
         onSourceComponentChanged: {
             width = Qt.binding( function() {
                 var width = dateRootItem.height > dateRootItem.width ? dateRootItem.width :dateRootItem.height
@@ -47,12 +48,17 @@
     }
 
     Loader{
-        width: units.gu(1)
-        height: width
-        anchors.horizontalCenter: parent.horizontalCenter
-        anchors.top: dateLabel.bottom
-        anchors.topMargin: dateRootItem.height/4
         sourceComponent: showEvent ? eventIndicatorComp : undefined
+        onSourceComponentChanged: {
+            width = Qt.binding( function() { return units.gu(1) })
+            height = Qt.binding( function() { return width })
+            anchors.horizontalCenter = Qt.binding( function() { return  parent.horizontalCenter })
+            anchors.top = Qt.binding( function() { return  parent.verticalCenter })
+            anchors.topMargin = Qt.binding( function() {
+                var w = (dateRootItem.height > dateRootItem.width ? dateRootItem.width :dateRootItem.height)/1.1
+                return (w/2) + units.gu(0.1)
+            });
+        }
     }
 
     Component{