ubuntu-touch-coreapps-reviewers team mailing list archive

[Arto Jalkanen <ajalkane@xxxxxxxxx>]

Review: Needs Information

Comment on line 35.

Diff comments:

> === modified file 'src/plugin/folderlistmodel/filesystemaction.cpp'
> --- src/plugin/folderlistmodel/filesystemaction.cpp	2015-07-18 21:50:43 +0000
> +++ src/plugin/folderlistmodel/filesystemaction.cpp	2015-07-18 21:50:44 +0000
> @@ -128,10 +128,36 @@
>      //it is not necessary to delete
>      auxAction      = 0;
>      copyFile.clear();
> -
> -}
> -
> -
> +    sourceLocation = 0;
> +    targetLocation = 0;
> +
> +}
> +
> +/*!
> + * \brief FileSystemAction::Action::toggleLocation()
> + *
> + *  It may be useful if there is a Undo Action to do a inverse Action
> + */
> +void FileSystemAction::Action::toggleLocation()
> +{
> +    Location * tmp   = sourceLocation;
> +    sourceLocation   = targetLocation;
> +    targetLocation   = tmp;
> +}
> +
> +/*!
> + * \brief FileSystemAction::Action::matchLocations
> + * \return true if sourceLocation is equal targetLocation
> + */
> +bool FileSystemAction::Action::matchLocations() const
> +{
> +    return sourceLocation == targetLocation;

I don't understand this. These are pointers to Location object. So it only compares if they are the same instance? It does not actually compare the objects are equal to each other. Is this the purpose?

> +}
> +
> +bool FileSystemAction::Action::isRemote() const
> +{
> +    return  sourceLocation->isRemote() || targetLocation->isRemote();
> +}
>  
>  //===============================================================================================
>  FileSystemAction::ActionEntry::ActionEntry(): newName(0)


-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-06/+merge/265197
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.