ubuntu-touch-coreapps-reviewers team mailing list archive

[Arto Jalkanen <ajalkane@xxxxxxxxx>]

Review: Approve

Thanks for the explanation, now it makes sense. I guess some clarification would be helpful there for people not so familiar with the details. 

I have three suggestions and you can decide whether to do one of them:

 - Add a comment to explain it
 - Use the type()
 - Create operator overload Location::operator==() to compare the objects and there do the pointer comparison.
-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-06/+merge/265197
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.