ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Riccardo Padovani has proposed merging lp:~rpadovani/reminders-app/fix-predictive-text into lp:reminders-app.

Commit message:
Fix text insertion in tags and notebooks' name edit

Requested reviews:
  Ubuntu Notes app developers (notes-app-dev)

For more details, see:
https://code.launchpad.net/~rpadovani/reminders-app/fix-predictive-text/+merge/271839

We enabled the use of the predictive text in commits 489 and 490.

The problem is, while the user is typing, the text property isn't updated. So if a user clicks 'ok' while is typing, part of the text is cut.

On the other hand, displayText has always the right text
-- 
Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~rpadovani/reminders-app/fix-predictive-text into lp:reminders-app.

=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml	2015-09-15 14:50:55 +0000
+++ src/app/qml/components/EditTagsDialog.qml	2015-09-21 16:35:29 +0000
@@ -65,7 +65,7 @@
                 onAccepted: accept();
 
                 function accept() {
-                    var tagName = text;
+                    var tagName = displayText;
                     text = '';
 
                     // Check if the tag exists

=== modified file 'src/app/qml/ui/NotebooksPage.qml'
--- src/app/qml/ui/NotebooksPage.qml	2015-09-15 14:50:55 +0000
+++ src/app/qml/ui/NotebooksPage.qml	2015-09-21 16:35:29 +0000
@@ -209,7 +209,7 @@
                 text: i18n.tr("OK")
                 enabled: nameTextField.text || nameTextField.inputMethodComposing
                 onClicked: {
-                    renameNotebookDialog.accepted(nameTextField.text)
+                    renameNotebookDialog.accepted(nameTextField.displayText)
                     PopupUtils.close(renameNotebookDialog)
                 }
             }