ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-deprecated-properties into lp:music-app.

Commit message:
* Remove some deprecated code for the UbuntuShape image property.

Requested reviews:
  Music App Developers (music-app-dev)

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-deprecated-properties/+merge/272347

* Remove some deprecated code for the UbuntuShape image property.

There are other instances related to using ListItems in UC1.2, but those will eventually be resolved as well.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-deprecated-properties into lp:music-app.

=== modified file 'app/components/Themes/Ambiance/BubbleShape.qml'
--- app/components/Themes/Ambiance/BubbleShape.qml	2015-06-20 17:49:57 +0000
+++ app/components/Themes/Ambiance/BubbleShape.qml	2015-09-25 08:13:29 +0000
@@ -112,7 +112,7 @@
         anchors.fill: parent
         borderSource: "none"
         color: Theme.palette.normal.overlay
-        image: bubbleShape.clipContent ? shapeSource : null
+        source: bubbleShape.clipContent ? shapeSource : null
         visible: !square
     }
 

=== modified file 'app/components/Walkthrough/Slide1.qml'
--- app/components/Walkthrough/Slide1.qml	2015-05-03 16:22:31 +0000
+++ app/components/Walkthrough/Slide1.qml	2015-09-25 08:13:29 +0000
@@ -37,11 +37,12 @@
                 horizontalCenter: parent.horizontalCenter
             }
             height: (parent.height - bodyText.contentHeight - introductionText.height - 4*units.gu(4))/2
-            image: Image {
+            radius: "medium"
+            source:  Image {
                 id: centerImage
                 source: Qt.resolvedUrl("../../graphics/music-app@xxxxxx")
             }
-            radius: "medium"
+
             width: height
         }
 

=== modified file 'debian/changelog'
--- debian/changelog	2015-09-08 14:18:46 +0000
+++ debian/changelog	2015-09-25 08:13:29 +0000
@@ -3,6 +3,9 @@
   [ Bartosz Kosiorek ]
   *  Reduce size of images (with tinypng.com) to decrease click size and improve performance
 
+  [ Victor Thompson ]
+  * Remove some deprecated code for the UbuntuShape image property.
+
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Tue, 08 Sep 2015 10:08:49 +0200
 
 music-app (2.2ubuntu1) vivid; urgency=medium