ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Approve

LGTM :-)

Diff comments:

> 
> === modified file 'app/components/Walkthrough/Slide1.qml'
> --- app/components/Walkthrough/Slide1.qml	2015-05-03 16:22:31 +0000
> +++ app/components/Walkthrough/Slide1.qml	2015-09-25 08:13:29 +0000
> @@ -37,11 +37,12 @@
>                  horizontalCenter: parent.horizontalCenter
>              }
>              height: (parent.height - bodyText.contentHeight - introductionText.height - 4*units.gu(4))/2
> -            image: Image {
> +            radius: "medium"

Yey, are you gain A-Z OCD like me? ;-)

> +            source:  Image {
>                  id: centerImage
>                  source: Qt.resolvedUrl("../../graphics/music-app@xxxxxx")
>              }
> -            radius: "medium"
> +
>              width: height
>          }
>  


-- 
https://code.launchpad.net/~vthompson/music-app/fix-deprecated-properties/+merge/272347
Your team Music App Developers is subscribed to branch lp:music-app.