ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Review: Needs Fixing

1 inline comment.

Diff comments:

> === modified file 'app/alarm/AlarmDelegate.qml'
> --- app/alarm/AlarmDelegate.qml	2015-08-17 18:28:28 +0000
> +++ app/alarm/AlarmDelegate.qml	2015-10-16 06:02:26 +0000
> @@ -137,11 +137,11 @@
>                  alarmData.enabled = checked
>  
>                  /*
> -                 Calculate the new alarm time if it is a one-time alarm and has
> -                 gone-off and the user is re-enabling the alarm. Repeating
> -                 alarms do this automatically.
> +                 Calculate the alarm time if it is a one-time alarm.
> +                 It is important to keep the alarm list in order of occurence (also for disabled alarms).

Occurrence is spelt incorrectly.

> +                 Repeating alarms do this automatically.
>                  */
> -                if(checked && type === Alarm.OneTime) {
> +                if(type === Alarm.OneTime) {
>                      alarmData.daysOfWeek = Alarm.AutoDetect
>                      var now = new Date()
>                      if (alarmData.date.getHours()*60+alarmData.date.getMinutes() <= now.getHours()*60+now.getMinutes()) {


-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix/+merge/274661
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.