ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix into lp:ubuntu-clock-app.

Commit message:
Disable alarms which have passed due to timezone changes (or phone is turned off) made by the user (LP: #1505522)

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
  Bug #1505522 in Ubuntu Clock App: "It is not possible to disable alarm which was passed"
  https://bugs.launchpad.net/ubuntu-clock-app/+bug/1505522

For more details, see:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix/+merge/274661

Disable alarms which have passed due to timezone changes (or phone is turned off) made by the user (LP: #1505522)
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix into lp:ubuntu-clock-app.

=== modified file 'app/alarm/AlarmDelegate.qml'
--- app/alarm/AlarmDelegate.qml	2015-08-17 18:28:28 +0000
+++ app/alarm/AlarmDelegate.qml	2015-10-16 06:02:26 +0000
@@ -137,11 +137,11 @@
                 alarmData.enabled = checked
 
                 /*
-                 Calculate the new alarm time if it is a one-time alarm and has
-                 gone-off and the user is re-enabling the alarm. Repeating
-                 alarms do this automatically.
+                 Calculate the alarm time if it is a one-time alarm.
+                 It is important to keep the alarm list in order of occurence (also for disabled alarms).
+                 Repeating alarms do this automatically.
                 */
-                if(checked && type === Alarm.OneTime) {
+                if(type === Alarm.OneTime) {
                     alarmData.daysOfWeek = Alarm.AutoDetect
                     var now = new Date()
                     if (alarmData.date.getHours()*60+alarmData.date.getMinutes() <= now.getHours()*60+now.getMinutes()) {

=== modified file 'debian/changelog'
--- debian/changelog	2015-09-17 04:33:11 +0000
+++ debian/changelog	2015-10-16 06:02:26 +0000
@@ -16,6 +16,7 @@
   * Fix stopwatch issue appering during changing timezone during runtime (LP: #1493358)
   * Fix Daylight Saving Time issues (LP: #1437805)
   * Fix time for second location wrong after daylight saving started (LP: #1457523)
+  * Disable alarms which have passed due to timezone changes made by the user (LP: #1505522)
 
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Wed, 02 Sep 2015 15:16:29 +0200