ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix into lp:ubuntu-clock-app

To: mp+274661@xxxxxxxxxxxxxxxxxx
From: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
Date: Fri, 16 Oct 2015 07:15:31 -0000
In-reply-to: <20151016060323.12333.66501.launchpad@ackee.canonical.com>
Reply-to: mp+274661@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Tiny little detail, the comment "It is important to keep the alarm list in order of occurrence (also for disabled alarms)." is not true. That if loop does not affect the alarm list order. Can you remove that statement?


-- 
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix/+merge/274661
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.

References

[Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix into lp:ubuntu-clock-app
From: Bartosz Kosiorek, 2015-10-16