ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-app-init into lp:ubuntu-docviewer-app/reboot

To: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
From: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
Date: Mon, 19 Oct 2015 22:43:08 -0000
In-reply-to: <20151018171710.16770.21740.launchpad@ackee.canonical.com>
Reply-to: mp+274806@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Currently config.h needs to be configured by CMake. Both in rev.193 (which has been approved by Jenkins) and rev. 195 that does not happen.

For what I understand, the Debian package created by Jenkins tries to load "@DATA_DIR@/qml/ubuntu-docviewer-app.qml", which is not a legal path.

Don't know how it successed with tests, since they should fail.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-app-init/+merge/274806
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot.