← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app

 

The proposal to merge lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app has been updated.

Description changed to:

This would be the theoretical correct approach forward if we want the alarm sound preview to reflect the alarm volume. However, as the alarm volume seems to be restored to what the setting in the clock app is before the alarm is triggered, the current alarm role volume does not necessarily reflect the upcoming alarm's volume. Because of this, it is arguable how much sense it makes to include this workaround.

A simpler workaround to the api breakage problem, with roughly the same outcome can be found here:
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179

For more details, see:
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app.