ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app.

Commit message:
drop alarm preview's audioRole
  
This doesn't really work as expected anyways and would cause issues
with an upcoming API change after upstreaming the roles patch.

Requested reviews:
  Ubuntu Clock Developers (ubuntu-clock-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app.

=== modified file 'app/alarm/AlarmSound.qml'
--- app/alarm/AlarmSound.qml	2015-08-28 20:06:32 +0000
+++ app/alarm/AlarmSound.qml	2015-10-21 12:20:03 +0000
@@ -149,7 +149,6 @@
 
     Audio {
         id: previewAlarmSound
-        audioRole: MediaPlayer.alert
 
         function controlPlayback(fileURL) {
             source = fileURL