ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Andrew Hayzen has proposed merging lp:~ahayzen/music-app/fix-1514143-workaround into lp:music-app.

Commit message:
* Workaround for bug 1514143 by locking the header when searching

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1514143 in Ubuntu Music App: "While searching often times the keyboard hides while typing"
  https://bugs.launchpad.net/music-app/+bug/1514143

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1514143-workaround/+merge/277611

* Workaround for bug 1514143 by locking the header when searching

The issue comes from using a flickable with a movable header, so for now the header is made static when in searching mode.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/fix-1514143-workaround into lp:music-app.

=== modified file 'app/components/HeadState/SearchHeadState.qml'
--- app/components/HeadState/SearchHeadState.qml	2015-08-12 23:36:44 +0000
+++ app/components/HeadState/SearchHeadState.qml	2015-11-16 18:24:27 +0000
@@ -56,6 +56,11 @@
                 if (state === "default") {
                     searchField.text = ""
                 }
+
+                // FIXME: Workaround for pad.lv/1514143 (keyboard show/hide on view moving)
+                // by locking the header and forcing a topMargin of page to the header height
+                headerState.head.locked = state === headerState.name;
+                thisPage.anchors.topMargin = state === headerState.name ? units.gu(6.125) : 0
             }
 
             onVisibleChanged: {

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-03 02:44:19 +0000
+++ debian/changelog	2015-11-16 18:24:27 +0000
@@ -12,6 +12,7 @@
 
   [ Andrew Hayzen ]
   * Switch to using the new uc1.3 listitems within the SDK
+  * Workaround for bug 1514143 by locking the header when searching (LP: #1514143)
 
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Tue, 08 Sep 2015 10:08:49 +0200