ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Review: Needs Fixing

This looks good! Just one small inline comment.

Diff comments:

> === modified file 'app/components/HeadState/SearchHeadState.qml'
> --- app/components/HeadState/SearchHeadState.qml	2015-08-12 23:36:44 +0000
> +++ app/components/HeadState/SearchHeadState.qml	2015-11-16 18:33:07 +0000
> @@ -56,6 +56,11 @@
>                  if (state === "default") {
>                      searchField.text = ""
>                  }
> +
> +                // FIXME: Workaround for pad.lv/1514143 (keyboard show/hide on view moving)
> +                // by locking the header and forcing a topMargin of page to the header height
> +                headerState.head.locked = state === headerState.name;
> +                thisPage.anchors.topMargin = state === headerState.name ? units.gu(6.125) : 0

I think we should put the same "FIXME" that have elsewhere for the 6.125 header height hardcoding.

>              }
>  
>              onVisibleChanged: {


-- 
https://code.launchpad.net/~ahayzen/music-app/fix-1514143-workaround/+merge/277611
Your team Music App Developers is subscribed to branch lp:music-app.