ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #07498
Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app
I got some time to reinstall Ubuntu Touch on my Nexus 5.
After some fight with LibreOffice dependencies, I've been able to test the UCUnits change on the device:
WITH DPIs - https://imgur.com/sc53rXF
WITH UCUNITS - https://imgur.com/i6DYb6e
The GRID_UNIT_PX env value on Nexus 5 is "23", and the result in the screenshot above is totally compatible with the test done on the BQ E5 (Nexus 5 has a wider screen in terms of units.gu() than mako and vegetahd).
I'm sure the same result is visible also on OPO and MX4.
@Alan: I really need this branch merged ASAP because it's a prerequisite for two other branches[1] in the queue.
I know you're busy with the UbuCon@LA but, since the other changes work well and the issue you've found has been fixed, I'm forced to by-pass your review and top-approve this. Sorry.
======
[1] 1st branch: Refactor of the zooming code, providing a single property called "zoomSettings", instead of individual ones (which are grouped in 'zoomSettings').
2nd branch: Show content centered on the screen + fixes for PinchArea + double-tap-to-zoom gesture
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.
References