← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mcintire-evan/ubuntu-terminal-app/desktop-dimensions into lp:ubuntu-terminal-app

 

Evan McIntire has proposed merging lp:~mcintire-evan/ubuntu-terminal-app/desktop-dimensions into lp:ubuntu-terminal-app.

Commit message:
Change the default dimensions so the terminal is a more proper size for desktops

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1465978 in Ubuntu Terminal App: "Use landscape dimensions if the app is running on the desktop"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1465978

For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/desktop-dimensions/+merge/284381

Change the default dimensions so the terminal is a more proper size for desktops
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/desktop-dimensions into lp:ubuntu-terminal-app.
=== modified file 'src/app/qml/ubuntu-terminal-app.qml'
--- src/app/qml/ubuntu-terminal-app.qml	2016-01-22 18:29:56 +0000
+++ src/app/qml/ubuntu-terminal-app.qml	2016-01-29 02:29:53 +0000
@@ -12,8 +12,8 @@
     applicationName: "com.ubuntu.terminal"
     automaticOrientation: true
 
-    width: units.gu(50)
-    height: units.gu(75)
+    width: units.gu(90)
+    height: units.gu(55)
 
     AuthenticationService {
         onDenied: Qt.quit();


Follow ups