ubuntu-touch-coreapps-reviewers team mailing list archive

[Roman Shchekin <mrqtros@xxxxxxxxx>]

Review: Needs Information

See inline comments...

Diff comments:

> === modified file 'src/app/qml/ubuntu-docviewer-app.qml'
> --- src/app/qml/ubuntu-docviewer-app.qml	2016-01-14 13:07:09 +0000
> +++ src/app/qml/ubuntu-docviewer-app.qml	2016-01-23 13:06:44 +0000
> @@ -29,10 +29,18 @@
>      objectName: "mainView"
>  
>      property bool pickMode: commandLineProxy.pickMode
> -    property bool fullscreen: commandLineProxy.fullscreen
> -
> -    readonly property bool wideWindow: width > units.gu(80)
> -    readonly property bool veryWideWindow: width > units.gu(120)
> +
> +    // If device orientation is landscape and screen width is limited,
> +    // force hiding Unity 8 indicators panel.
> +    property bool fullscreen: commandLineProxy.fullscreen ||
> +                              (!desktopMode && isLandscape && narrowWindow) ||
> +                              pageStack.currentPage.hasOwnProperty("isPresentation")
> +
> +    readonly property bool desktopMode: DocumentViewer.desktopMode
> +

Can you explain why did you left that gape (51..80)? Is it something like "normal window"?

> +    readonly property bool narrowWindow: width < units.gu(51)
> +    readonly property bool wideWindow: width >= units.gu(80) && width < units.gu(120)
> +    readonly property bool veryWideWindow: width >= units.gu(120)
>      readonly property bool isLandscape: Screen.orientation == Qt.LandscapeOrientation ||
>                                          Screen.orientation == Qt.InvertedLandscapeOrientation
>  


-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-full-screen/+merge/283718
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.