ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

To: Evan McIntire <mcintire.evan@xxxxxxxxx>
From: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
Date: Sat, 13 Feb 2016 11:17:28 -0000
In-reply-to: <20160213040223.6392.19770.launchpad@ackee.canonical.com>
Reply-to: mp+284502@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Yes, it's more a workaround than a "rock-solid" solution, but it does the job well and don't require to change things where it's not strictly required.

Below the Timer {}, I see that you left the Component.onCompleted handler. It isn't necessary anymore.

Anyway, LGTM, so there's no reason why I shouldn't approve it. Great work! :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app.

References

[Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app
From: Evan McIntire, 2016-02-13