ubuntu-touch-coreapps-reviewers team mailing list archive

[Evan McIntire <mcintire.evan@xxxxxxxxx>]

Evan McIntire has proposed merging lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app.

Commit message:
Autofocus the authentication popup at app launch. In addition, only load the terminal page after auth is complete/not required so that it doesnt not steal focus, which allowed users to use a bluetooth keyboard to bypass authentication

Requested reviews:
  Niklas Wenzel (nikwen)
  Stefano Verzegnassi (verzegnassi-stefano)
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1488481 in Ubuntu Terminal App: "BQ (r24): terminal-app shows terminal data when asking for password"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1488481
  Bug #1499994 in Ubuntu Terminal App: "When prompting for password, focus is not set to password entry box"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1499994

For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502

Autofocus the authentication popup at app launch
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app.

=== modified file 'src/app/qml/AuthenticationDialog.qml'
--- src/app/qml/AuthenticationDialog.qml	2016-01-22 17:50:33 +0000
+++ src/app/qml/AuthenticationDialog.qml	2016-02-13 04:00:46 +0000
@@ -29,6 +29,15 @@
     signal passwordEntered(string password)
     signal dialogCanceled
 
+    // Due to several different things forcing focus
+    // on creation, we simply create this timer to
+    // work around that (see bugs #1488481 and #1499994)
+    Timer {
+        interval: 1
+        running: true
+        onTriggered: passwordField.forceActiveFocus()
+    }
+
     Component.onCompleted: {
         passwordField.forceActiveFocus();
     }
@@ -36,7 +45,6 @@
     TextField {
         id: passwordField
         objectName: "inputField"
-
         placeholderText: i18n.tr("passcode or passphrase")
         echoMode: TextInput.Password