ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1538829-no-playlists-label into lp:music-app.

Commit message:
* Fix topMargin of the Playlists empty state so title is not obscurred

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1538829 in Ubuntu Music App: "When the app is in landscape mode on mako the "No playlists found" label is not visible"
  https://bugs.launchpad.net/music-app/+bug/1538829

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1538829-no-playlists-label/+merge/287415

* Fix topMargin of the Playlists empty state so title is not obscurred
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1538829-no-playlists-label into lp:music-app.

=== modified file 'app/components/PlaylistsEmptyState.qml'
--- app/components/PlaylistsEmptyState.qml	2015-08-12 23:36:44 +0000
+++ app/components/PlaylistsEmptyState.qml	2016-02-28 20:16:13 +0000
@@ -24,7 +24,9 @@
 Rectangle {
     id: playlistsEmptyState
     anchors {
-        fill: parent
+        top: parent.top
+        topMargin: units.gu(11.5)
+        bottom: parent.bottom
     }
     color: mainView.backgroundColor
 

=== modified file 'debian/changelog'
--- debian/changelog	2016-02-28 01:18:29 +0000
+++ debian/changelog	2016-02-28 20:16:13 +0000
@@ -7,6 +7,7 @@
   * Ensure that only one ContentHubExport page is open (LP: #1538863).
   * Fix fallback image path in MusicListItem (LP: #1549580).
   * Fix regression where AddToPlaylist.qml no long supports plural track counts (LP: #1550832).
+  * Fix topMargin of the Playlists empty state so title is not obscurred (LP: #1538829).
 
   [ Andrew Hayzen ]
   * Fix so that a press and hold cannot disable selection in the ContentHubExport.qml (LP: #1538838)