ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Review: Needs Information

One inline comment.

Diff comments:

> === modified file 'app/components/PlaylistsEmptyState.qml'
> --- app/components/PlaylistsEmptyState.qml	2015-08-12 23:36:44 +0000
> +++ app/components/PlaylistsEmptyState.qml	2016-02-28 20:16:13 +0000
> @@ -24,7 +24,9 @@
>  Rectangle {
>      id: playlistsEmptyState
>      anchors {
> -        fill: parent
> +        top: parent.top

Why not use verticalCenter: parent.verticalCenter instead? Otherwise small height displays will then end up with the text off the bottom of the display? And it is interesting that the centerIn: parent of the Column doesn't work...

> +        topMargin: units.gu(11.5)
> +        bottom: parent.bottom
>      }
>      color: mainView.backgroundColor
>  


-- 
https://code.launchpad.net/~vthompson/music-app/fix-1538829-no-playlists-label/+merge/287415
Your team Music App Developers is subscribed to branch lp:music-app.