ubuntu-touch-coreapps-reviewers team mailing list archive

[Renato Araujo Oliveira Filho <renato.filho@xxxxxxxxxxxxx>]

Review: Needs Information

only single comment.

Diff comments:

> === added file 'click-build.sh'
> --- click-build.sh	1970-01-01 00:00:00 +0000
> +++ click-build.sh	2016-03-16 19:14:56 +0000
> @@ -0,0 +1,16 @@
> +#!/bin/sh
> +
> +export LC_ALL=C
> +
> +BZR_SOURCE=${1:-lp:ubuntu-calendar-app}
> +
> +CLICKARCH=armhf
> +rm -rf $CLICKARCH-build
> +mkdir $CLICKARCH-build
> +cd $CLICKARCH-build
> +cmake .. -DCLICK_MODE=on \
> +        -DBZR_REVNO=$(cd ..; bzr revno) \
> +        -DBZR_SOURCE="$BZR_SOURCE"
> +make DESTDIR=../package install

could you create the install dir inside of build dir? It will be easy to clean it. And keep it away from source dir (monitored by bzr)

> +cd ..
> +click build package


-- 
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-build_click/+merge/289280
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.