ubuntu-touch-coreapps-reviewers team mailing list archive

[Renato Araujo Oliveira Filho <renato.filho@xxxxxxxxxxxxx>]

Review: Needs Information

Whats happen on NewEvent page? Do we need something special when editing a event with end date null?



Diff comments:

> 
> === modified file 'TimeLineBase.qml'
> --- TimeLineBase.qml	2016-03-03 21:42:08 +0000
> +++ TimeLineBase.qml	2016-03-16 19:14:10 +0000
> @@ -95,8 +95,15 @@
>                          dirty = true
>                      }
>                      if (e.endDateTime.getTime() != events[i].eventEndTime) {
> -                        console.warn("Event does not match end time")
> -                        dirty = true
> +                        if (!isNaN(e.endDateTime.getTime()) && !isNaN(events[i].eventEndTime)) {

this is wrong. this will cause the view to be update forever.

This check needs to verify if the event enddatetime is different from map endTime. This implementation will mark the view as dirty if the dates are not null (which is the most of the cases).

> +                            console.warn("Event does not match end time")
> +                            dirty = true
> +                        } else {
> +                            // Sometimes when both star and end time are equals
> +                            // end time is reported as empty
> +                            e.endDateTime = e.startDateTime
> +                            events[i].eventEndTime = events[i].eventStartTime
> +                        }
>                      }
>  
>                      if (dirty) {


-- 
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582/+merge/289278
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.