ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-search-field-white-text into lp:music-app.

Commit message:
* Fix the Search TextField component color so the text is not invisible when field is not in focus

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1550096 in Ubuntu Music App: "Potential music app updates needed due to a change in theming/UI toolkit in OTA10"
  https://bugs.launchpad.net/music-app/+bug/1550096

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-search-field-white-text/+merge/291068

* Fix the Search TextField component color so the text is not invisible when field is not in focus

This should probably be reported in an SDK bug regarding the Suru theme when the TextField is not in focus. This is only a workaround.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-search-field-white-text into lp:music-app.

=== modified file 'app/components/HeadState/SearchHeadState.qml'
--- app/components/HeadState/SearchHeadState.qml	2016-02-26 20:09:49 +0000
+++ app/components/HeadState/SearchHeadState.qml	2016-04-06 01:56:48 +0000
@@ -36,6 +36,7 @@
             right: parent ? parent.right : undefined
             rightMargin: units.gu(2)
         }
+        color: UbuntuColors.ash
         hasClearButton: true
         inputMethodHints: Qt.ImhNoPredictiveText
         placeholderText: i18n.tr("Search music")

=== modified file 'debian/changelog'
--- debian/changelog	2016-03-23 02:12:30 +0000
+++ debian/changelog	2016-04-06 01:56:48 +0000
@@ -11,6 +11,7 @@
   * Fix topMargin of the Playlists empty state so title is not obscurred (LP: #1538829).
   * Fix fallback art when the it is linked to the Player's currentMeta (LP: #1549557).
   * Update a number of components to work properly with new color palette in the SDK (LP: #1550096).
+  * Fix the Search TextField component color so the text is not invisible when field is not in focus (LP: #1550096).
 
   [ Andrew Hayzen ]
   * Fix so that a press and hold cannot disable selection in the ContentHubExport.qml (LP: #1538838)