ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app

To: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
From: Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>
Date: Thu, 07 Apr 2016 22:26:17 -0000
In-reply-to: <20160406162536.25209.14305.launchpad@ackee.canonical.com>
Reply-to: mp+291139@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Why not load the textfield dynamically. This way when it is loaded, it automatically gets focus and shows OSK, and when it is unloaded, the OSK also hides. And you save a tiny memory footprint :P. Also this way you don't need to force focus on the scrollView on component.onCompleted, thereby removing the workarounds.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard/+merge/291139
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app.

References

[Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app
From: Stefano Verzegnassi, 2016-04-06