ubuntu-touch-coreapps-reviewers team mailing list archive

[Florian Boucault <florian.boucault@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'MonthComponent.qml'
> --- MonthComponent.qml	2016-04-28 20:19:03 +0000
> +++ MonthComponent.qml	2016-08-05 15:58:58 +0000
> @@ -214,6 +215,15 @@
>              return monthGrid.childAt(clickPosition.x, clickPosition.y)
>          }
>  
> +        function getIndexOfChild(object, child) {

Because monthGrid.children does not have an indexOf() method

> +            for (var i = 0; i <= object.children.length; i++) {
> +                if (object.children[i] === child) {
> +                    return i;
> +                }
> +            }
> +            return -1;
> +        }
> +
>          anchors {
>              fill: column
>              topMargin: monthGrid.y


-- 
https://code.launchpad.net/~fboucault/ubuntu-calendar-app/startup_time/+merge/302163
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~fboucault/ubuntu-calendar-app/startup_time into lp:ubuntu-calendar-app.