ubuntu-touch-coreapps team mailing list archive

[Joey Chan <qqworini@xxxxxxxxx>]

Haha, take it easy  :P

I just afraid u would request any merge before Hack Day,  I am very care
about the code quality.
Remember this is open source project, we r contributing to the whole field,
and we r fighting at the front line.  :)

br,
Joey


2013/7/17 <mrqtros@xxxxxxxxx>

> Joey, keep my implementation untouched, please. I will use your module
> soon. Just give me to do my part myself, I'll do it right way. I
> implemented in my own way because we haven't stable trunk and all of us
> work hard right now, always something changes. Sometimes one of us can
> change thing on which another rely. And some features will be missing.
>
> You want to save your correct version with column delegate - of course,
> your code - you decide. But let me save my page-built-in network part too ;)
>
>
> Please, keep my implementation unmodified. Thanks!
>
> 17.07.13 13:41 Joey Chan написал(а):
> I think u may make "add feed" bit complicated.
>
> I already implement the "add feed" page, once a feed is added to db, a
> signal will emit with feed info, then this feed will add to XmlNetwork for
> automatic downloading, the status will be change in the XmlNetwork error
> handler.
> I want every module just do what they need to do, leave other jobs to
> someone else.
>
>
> 2013/7/17 <mrqtros@xxxxxxxxx>
>
>> Hi, Joey!
>>
>>
>> 1. Ok, I'll try to do it today.
>>
>>
>> 2. Let's preserve two network modules for a while. I'll merge their
>> functionality soon. Cost is very little, kilobytes of memory =)
>>
>> I thought about your implementation - no need to change anything, since
>> your code is using for update (no need to change status), but my for
>> appending new feeds (need to change status).
>>
>> 17.07.13 12:29 Joey Chan написал(а):
>> Hi Roman,
>>
>> Could u separate ur code yourself ? there r too much code in the main qml
>> file, also u have ur own network module there.
>>
>> 1. those "pages" in ubuntu-rssreader-app.qml need to be separated into
>> several qml files;
>> 2. pls tell me what features u need in the network module, like the
>> status, this can be handle in the error handler which had not start coding
>> yet.  I just want all network functions in one place;
>> 3. take ur time, quality first  :)
>>
>>
>> BR,
>> Joey
>>
>>
>> 2013/7/17 Roman Shchekin <mrqtros@xxxxxxxxx>
>>
>>> BTW, Has anyone tested swipe-to-remove? :) Try it in "Topics" page.
>>>
>>> BR,
>>> Roman.
>>>
>>>
>>> 2013/7/17 Roman Shchekin <mrqtros@xxxxxxxxx>
>>>
>>>> Hi everybody!
>>>>
>>>> Svenn, thanks for your comments! All of them are reasonable.
>>>>
>>>> 1. Experiment only :) I like CheckBox too, it's looks awesome!
>>>>
>>>> 2. Let's all think over! I really want to hear comments from Lisette.
>>>>
>>>> 3. Forgot one little thing! Yes, it works well, but only for feeds with
>>>> status '1' (append new feed via my pages and try to edit it. Joey will fix
>>>> it, he don't uses field "status" in DB on which I rely)
>>>>
>>>> And look - one page contains two methods to add feeds (toolbar and
>>>> button). I left both of them. We can decide their future in discussion. And
>>>> a lot of other things, like must feed can be binded to many topics or not.
>>>> And so on. I've a lot of questions, which I can't solve only myself :)
>>>>
>>>> Have a good day,
>>>> Roman!
>>>>
>>>>
>>>> 2013/7/17 Svenn-Arne Dragly <s@xxxxxxxxxx>
>>>>
>>>>> Great work, Roman!
>>>>>
>>>>> It looks really nice and felt very intuitive to use.
>>>>>
>>>>> A few comments, though:
>>>>>
>>>>> 1. You are using CheckBox in the Add Topic view to select feeds, while
>>>>> we use Switch in the Add Feed view to select topics. Perhaps both
>>>>> should use the same component? Personally I prefer the CheckBox.
>>>>>
>>>>> 2. Also, I think long press + Remove on a feed should remove it from
>>>>> the topic only. If it exists in only one topic, it could be removed
>>>>> completely.
>>>>>
>>>>> 3. By the way, editing an existing feed seems not to work. Is it
>>>>> implemented yet?
>>>>>
>>>>> I have split the new pages into separate files and changed from Switch
>>>>> to CheckBox in the following branch. Feel free to merge it into your
>>>>> branch or to the alpha-branch:
>>>>>
>>>>> lp:~dragly/ubuntu-rssreader-app/topics-management-branch
>>>>>
>>>>>
>>>>>
>>>>> Best regards,
>>>>> Svenn-Arne
>>>>>
>>>>> On Tue 16 Jul 2013 10:59:37 PM CEST, Roman Shchekin wrote:
>>>>> > And here you are, folks, my topics and feeds management for alpha:
>>>>> > lp:~mrqtros/ubuntu-rssreader-app/topics-management-branch
>>>>> >
>>>>> > I hope you like it! (Keep in mind that some solutions are results of
>>>>> > sdk issues).
>>>>> >
>>>>> > P.S. Joey, especially to you - look, I've added 5 pages (4 complete
>>>>> > and 1 just sketch), separate them to files please as you want and
>>>>> > merge with you alpha version. Am I so tired to do this today myself
>>>>> > and I have a lot of businesses tomorrow :(
>>>>> > As you can see - I used deep navigation - as result our app become
>>>>> > extremely clear and simple, but in the same time very useful!
>>>>> >
>>>>> >
>>>>> > 2013/7/17 Roman Shchekin <mrqtros@xxxxxxxxx <mailto:
>>>>> mrqtros@xxxxxxxxx>>
>>>>> >
>>>>> >     Hi all!
>>>>> >
>>>>> >     Lisette, where we can find icons? :)
>>>>> >     We are still using the same "avatar.png" for all toolbar items, I
>>>>> >     already hate it :D
>>>>> >     Please, make me happy :))
>>>>> >
>>>>> >     BR,
>>>>> >     Roman!
>>>>> >
>>>>> >
>>>>> >     2013/7/16 Joey Chan <qqworini@xxxxxxxxx <mailto:
>>>>> qqworini@xxxxxxxxx>>
>>>>> >
>>>>> >         Opsss...  just two button for testing, forgot to remove them
>>>>>   :P
>>>>> >
>>>>> >
>>>>> >         2013/7/16 Lisette Slegers <lisette.slegers@xxxxxxxxxxxxx
>>>>> >         <mailto:lisette.slegers@xxxxxxxxxxxxx>>
>>>>> >
>>>>> >             Hi Joey!
>>>>> >
>>>>> >             I was just looking at the latest RSS reader branch (which
>>>>> >             is awesome!), and I was wondering about 2 toolbar actions
>>>>> >             in the article view: Index 0 and Index 1. See
>>>>> >             screenshot:
>>>>> https://docs.google.com/file/d/0B5ZePTRp2C_JTm9UaFJua05QXzQ/edit?usp=sharing
>>>>> >
>>>>> >             What are they?
>>>>> >
>>>>> >             Thanks,
>>>>> >             Lisette
>>>>> >
>>>>> >
>>>>> >
>>>>> >         --
>>>>> >         Mailing list: https://launchpad.net/~ubuntu-touch-coreapps
>>>>> >         Post to     : ubuntu-touch-coreapps@xxxxxxxxxxxxxxxxxxx
>>>>> >         <mailto:ubuntu-touch-coreapps@xxxxxxxxxxxxxxxxxxx>
>>>>> >         Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps
>>>>> >         More help   : https://help.launchpad.net/ListHelp
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>
>>
>
>