← Back to team overview

ubuntu-touch-coreapps team mailing list archive

PageHeader vs Flickable.topMarging behavior change heads up!

 

As this bug
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1572525
made clear, there is a change in behavior when you are using a PageHeader
with a Flickable that does not initially have topMargin 0. The PageHeader
used to override the topMargin of its flickable and set it to
header.height, but now it *adds* the header.height to the existing
Flickable topMargin. This was done for apps that require to have a specific
topMargin to work with the header, and to solve some bugs where the
topMargin was not always correctly reverted when multiple headers have the
same value for flickable set.

So if you have an app using PageHeader that has a Flickable where you do
not touch the topMargin, you should be fine. But if you are setting a
custom topMargin the behavior may change, so please test your app with the
latest UI Toolkit from rc-proposed. If there are any issues that you get
stuck with, feel free to contact me (t1mp in #ubuntu-app-devel) or reply to
this e-mail.

Greets,
Tim.