ubuntu-translations-coordinators team mailing list archive

[Gabor Kelemen <kelemeng@xxxxxxxx>]

Public bug reported:

This started in bug #775659, where check-new-release-gtk's i18n system
was seen coughing (again). During fixing that bug, It turned out that
many more executables are coughing as well. Let's see what's wrong here:

- check-new-release-gtk: see
https://launchpadlibrarian.net/85548451/notsupported.png - strings
appear untranslated again, like the window title. This is because my
patch for bug #775659 removed the "from gettext import gettext as _"
line, but later it came back: http://bazaar.launchpad.net/~ubuntu-core-
dev/update-manager/main/revision/2153#check-new-release-gtk

This is apparently incompatible with gettext.install(), or more
precisely: the gettext API and the class-based API are incompatible.

Simply removing the mentioned line fixes the localization of strings
from c-n-r-g, but not of those in the popup window. Those are from
UpdateManager/UpdateManager.py, which has an "import gettext as _" line,
like most of update-managers source files do  - incompatibility strikes
again.

I propose to get rid of the use of the class-based API entirely, and
fall back to the gettext one. The original reason to use it was bug
#557804, and that problem can be worked around (with a few lines stolen
from aptdaemon) until Python 3 comes to our rescue.

- do-release-upgrade, update-manager: these work fine as of now, but
because of the above, gettext.install() must be replaced and the --help
crash worked around.

- update-manager-text: this does not use gettext.install(), but plainly
crashes when called with --help.

- ubuntu-support-status: this has only a stub of i18n support.

Also the last two are not listed in POTFILES.in.

I'll propose a branch to merge that fixes all of these problems.

** Affects: ubuntu-translations
     Importance: High
         Status: Triaged

** Affects: update-manager (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: ubuntu-translations
   Importance: Undecided
       Status: New

** Branch linked: lp:~kelemeng/update-manager/fix-i18n-init

** Changed in: ubuntu-translations
       Status: New => Triaged

** Changed in: ubuntu-translations
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Translations Coordinators, which is subscribed to Ubuntu Translations.
https://bugs.launchpad.net/bugs/897276

Title:
  Fix up i18n support

Status in Ubuntu Translations:
  Triaged
Status in “update-manager” package in Ubuntu:
  New

Bug description:
  This started in bug #775659, where check-new-release-gtk's i18n system
  was seen coughing (again). During fixing that bug, It turned out that
  many more executables are coughing as well. Let's see what's wrong
  here:

  - check-new-release-gtk: see
  https://launchpadlibrarian.net/85548451/notsupported.png - strings
  appear untranslated again, like the window title. This is because my
  patch for bug #775659 removed the "from gettext import gettext as _"
  line, but later it came back: http://bazaar.launchpad.net/~ubuntu-
  core-dev/update-manager/main/revision/2153#check-new-release-gtk

  This is apparently incompatible with gettext.install(), or more
  precisely: the gettext API and the class-based API are incompatible.

  Simply removing the mentioned line fixes the localization of strings
  from c-n-r-g, but not of those in the popup window. Those are from
  UpdateManager/UpdateManager.py, which has an "import gettext as _"
  line, like most of update-managers source files do  - incompatibility
  strikes again.

  I propose to get rid of the use of the class-based API entirely, and
  fall back to the gettext one. The original reason to use it was bug
  #557804, and that problem can be worked around (with a few lines
  stolen from aptdaemon) until Python 3 comes to our rescue.

  - do-release-upgrade, update-manager: these work fine as of now, but
  because of the above, gettext.install() must be replaced and the
  --help crash worked around.

  - update-manager-text: this does not use gettext.install(), but
  plainly crashes when called with --help.

  - ubuntu-support-status: this has only a stub of i18n support.

  Also the last two are not listed in POTFILES.in.

  I'll propose a branch to merge that fixes all of these problems.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-translations/+bug/897276/+subscriptions