ubuntu-webapps-bugs team mailing list archive

[Olivier Tilloy <olivier.tilloy@xxxxxxxxxxxxx>]

Public bug reported:

There are two issues in one:

1. if a user has only one bookmark, she creates a new tab, the new tab
view is displayed, if she then switches to another open tab that has
this bookmark page open and unstars it from the address bar, and
switches back to the new tab view, the bookmark has disappeared, but the
bookmarks section header is still there, empty

2. if a user has no bookmarks, she creates a new tab, the new tab view
is displayed (with no bookmarks section), if she then switches to
another open tab and stars it, then switches back to the new tab view,
there is no bookmarks section displayed.

Those two issues boil down to the static nature of the sectionsModel in NewTabView.qml.
Instead of conditionally populating the model when the view is instantiated, the model should always contain the two sections, but the delegate in charge of displaying the sections should be visible only if the corresponding sub-model is not empty.

** Affects: webbrowser-app
     Importance: Medium
         Status: Triaged

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to webbrowser-app.
https://bugs.launchpad.net/bugs/1389605

Title:
  Bookmarks section header in new tab view not updated when a bookmark
  is added/removed

Status in Web Browser App:
  Triaged

Bug description:
  There are two issues in one:

  1. if a user has only one bookmark, she creates a new tab, the new tab
  view is displayed, if she then switches to another open tab that has
  this bookmark page open and unstars it from the address bar, and
  switches back to the new tab view, the bookmark has disappeared, but
  the bookmarks section header is still there, empty

  2. if a user has no bookmarks, she creates a new tab, the new tab view
  is displayed (with no bookmarks section), if she then switches to
  another open tab and stars it, then switches back to the new tab view,
  there is no bookmarks section displayed.

  Those two issues boil down to the static nature of the sectionsModel in NewTabView.qml.
  Instead of conditionally populating the model when the view is instantiated, the model should always contain the two sections, but the delegate in charge of displaying the sections should be visible only if the corresponding sub-model is not empty.

To manage notifications about this bug go to:
https://bugs.launchpad.net/webbrowser-app/+bug/1389605/+subscriptions